Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Python and R bulk client APIs #2162

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Implement Python and R bulk client APIs #2162

wants to merge 12 commits into from

Conversation

johngrimes
Copy link
Member

Resolves #1776.

@johngrimes johngrimes added the new feature New feature or request label Feb 23, 2025
@johngrimes johngrimes self-assigned this Feb 23, 2025
@johngrimes johngrimes marked this pull request as ready for review February 28, 2025 04:19
@johngrimes johngrimes requested a review from piotrszul February 28, 2025 04:19
piotrszul
piotrszul reviewed Feb 28, 2025
View reviewed changes
Copy link
Collaborator

@piotrszul piotrszul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
The only suggestion is to perhaps simplify the python bulk client API to only have one constructor that infers the export level form the arguments (group, patient) the in the same manner as the R API (or the bulk() datasource) does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piotrszul piotrszul piotrszul left review comments

Assignees

@johngrimes johngrimes

Labels
new feature New feature or request
Projects
Pathling
Status: In progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bulk FHIR client
2 participants
@johngrimes @piotrszul