Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNT] Adding Scorecard.yml Workflow and Scorecard Badge GOSST #1619

Merged
merged 6 commits into from
Jul 11, 2024

Conversation

PatriceJada
Copy link
Contributor

@PatriceJada PatriceJada commented Jun 7, 2024

Reference Issues/PRs

What does this implement/fix? Explain your changes.

This implementation integrates the OpenOSSF Scorecard, which provides an overview of the security health of the repository. The Scorecard analyzes the repository based on various security metrics, including code review, dependencies, CI/CD configurations, and more.

Does your contribution introduce a new dependency? If yes, which one?

Any other comments?

Part of GSOC

PR checklist

For all contributions
  • I've added myself to the list of contributors. Alternatively, you can use the @all-contributors bot to do this for you.
  • The PR title starts with either [ENH], [MNT], [DOC], [BUG], [REF], [DEP] or [GOV] indicating whether the PR topic is related to enhancement, maintenance, documentation, bugs, refactoring, deprecation or governance.
For new estimators and functions
  • I've added the estimator to the online API documentation.
  • (OPTIONAL) I've added myself as a __maintainer__ at the top of relevant files and want to be contacted regarding its maintenance. Unmaintained files may be removed. This is for the full file, and you should not add yourself if you are just making minor changes or do not want to help maintain its contents.
For developers with write access
  • (OPTIONAL) I've updated aeon's CODEOWNERS to receive notifications about future changes to these files.

@PatriceJada PatriceJada requested a review from a team as a code owner June 7, 2024 03:52
@aeon-actions-bot
Copy link
Contributor

Thank you for contributing to aeon

I did not find any labels to add based on the title. Please add the [ENH], [MNT], [BUG], [DOC], [REF], [DEP] and/or [GOV] tags to your pull requests titles. For now you can add the labels manually.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

@MatthewMiddlehurst
Copy link
Member

Thanks for the PR and best of luck on your GSoC project. Let us know if you need any help from our side.

@MatthewMiddlehurst
Copy link
Member

By the look of things requires google/oss-fuzz#12053 first?

@PatriceJada PatriceJada force-pushed the PatriceJada-patch-1 branch from 9b22d21 to d83d65f Compare July 3, 2024 22:24
@MatthewMiddlehurst MatthewMiddlehurst changed the title [WIP] Adding Scorecard.yml Workflow and Scorecard Badge GOSST [MNT] Adding Scorecard.yml Workflow and Scorecard Badge GOSST Jul 4, 2024
@MatthewMiddlehurst MatthewMiddlehurst added the maintenance Continuous integration, unit testing & package distribution label Jul 4, 2024
@MatthewMiddlehurst MatthewMiddlehurst marked this pull request as draft July 4, 2024 09:15
@PatriceJada
Copy link
Contributor Author

@MatthewMiddlehurst No, this is its own separate thing

@MatthewMiddlehurst MatthewMiddlehurst marked this pull request as ready for review July 9, 2024 14:46
Copy link
Member

@MatthewMiddlehurst MatthewMiddlehurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, but have a few comments. The badge currently shows nothing, but I assume that will change when a report is uploaded?

.github/workflows/scorecard.yml Outdated Show resolved Hide resolved
.github/workflows/scorecard.yml Outdated Show resolved Hide resolved
@PatriceJada PatriceJada force-pushed the PatriceJada-patch-1 branch from a0ffd58 to 3145022 Compare July 10, 2024 04:53
Copy link
Member

@MatthewMiddlehurst MatthewMiddlehurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think the pre-commit action does not like the force pushes, but not really relevant 🙂.

@MatthewMiddlehurst MatthewMiddlehurst merged commit 6e5b1d5 into aeon-toolkit:main Jul 11, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Continuous integration, unit testing & package distribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants