Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[KO-295] Changing MultiPodPerHost from bool to bool pointer #274

Merged
merged 6 commits into from
Mar 15, 2024
Merged

[KO-295] Changing MultiPodPerHost from bool to bool pointer #274

merged 6 commits into from
Mar 15, 2024

Conversation

tanmayja
Copy link
Contributor

No description provided.

abhishekdwivedi3060
abhishekdwivedi3060 approved these changes Mar 4, 2024
View reviewed changes
controllers/rack.go Show resolved Hide resolved
@sud82
Copy link
Collaborator

sud82 commented Mar 13, 2024

ptr.Deref(r.aeroCluster.Spec.PodSpec.MultiPodPerHost, false) is used in many places, and false is getting repeated.
Lets implement a wrapper func
getBool(r.aeroCluster.Spec.PodSpec.MultiPodPerHost) for
ptr.Deref(r.aeroCluster.Spec.PodSpec.MultiPodPerHost, false)

@sud82 sud82 merged commit cb72712 into master Mar 15, 2024
8 of 9 checks passed
@sud82 sud82 deleted the ko295 branch April 24, 2024 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhishekdwivedi3060 abhishekdwivedi3060 abhishekdwivedi3060 approved these changes

@sud82 sud82 sud82 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tanmayja @sud82 @abhishekdwivedi3060