KO-372: Drop support for old server versions and K8s APIs #337
+485
−36,800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
abhishekdwivedi3060
commented
Jan 13, 2025
•
abhishekdwivedi3060
commented
- Dropped support for v1beta1 AerospikeCluster API
- Dropped support for server version < 6.0
abhishekdwivedi3060
changed the title
tanmayja
reviewed
Jan 23, 2025
| newVersion, oldVersion string, newSpec, oldSpec *AerospikeConfigSpec) error { | ||
| ovflag, err := IsSecurityEnabled(oldVersion, oldSpec) | ||
| func validateSecurityContext(newSpec, oldSpec *AerospikeConfigSpec) error { | ||
| ovflag, err := IsSecurityEnabled(oldSpec) | ||
| if err != nil { | ||
| if !errors.Is(err, internalerrors.ErrNotFound) { |
There was a problem hiding this comment.
IsSecurityEnabled will never return ErrNotFound type error, this is being handled in the IsSecurityEnabled definition
check other places also.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.