Remove AeSdk:initializeContract #1915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1915 +/- ##
===========================================
- Coverage 80.33% 80.29% -0.04%
===========================================
Files 104 104
Lines 3570 3568 -2
Branches 771 771
===========================================
- Hits 2868 2865 -3
Misses 384 384
- Partials 318 319 +1 ☔ View full report in Codecov by Sentry. |
davidyuk
force-pushed
the
feature/remove-initialize-contract
branch
from
c71edf2 to
5c9fb9b
Compare
davidyuk
force-pushed
the
feature/remove-initialize-contract
branch
from
5c9fb9b to
bf84fca
Compare
BREAKING CHANGE: `AeSdk:initializeContract` removed
Use `Contract.initialize` instead:
```diff
- aeSdk.initializeContract(options)
+ Contract.initialize({ ...aeSdk.getContext(), ...options })
```
davidyuk
force-pushed
the
feature/remove-initialize-contract
branch
from
bf84fca to
00b4f86
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AeSdk:initializeContract makes AeSdk to depend on Contract, and to depend on @aeternity/aepp-calldata eventually.
closes partially #1839
This PR is supported by the Æternity Crypto Foundation