feat: Active accounts chart 2 #1006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🧪️ Preview Links 🔎️Mainnet: https://pr-1006-aescan.stg.service.aepps.com |
Co-authored-by: Michele F. <[email protected]>
Co-authored-by: Michele F. <[email protected]>
Co-authored-by: Michele F. <[email protected]>
Co-authored-by: Michele F. <[email protected]>
janmichek
commented
Dec 13, 2024
| totalAccountsCount.value = null | ||
| const { data } = await axios.get(`${MIDDLEWARE_URL}/v3/stats/total-accounts?interval_by=month&limit=100`) | ||
| // todo ask mdw for endpoint | ||
| totalAccountsCount.value = data.data.reduce((total, item) => total + parseInt(item.count), 0) |
There was a problem hiding this comment.
It works based on manually summing the accounts from time fragments. Which is ok for now, not a clean solution.
Clean solution followup #1009
janmichek
commented
Dec 13, 2024
| <td>$ {{ formatNullable(formatNumber(coinW?.price)) }}</td> | ||
| <td>$ {{ formatNullable(formatNumber(coinW?.volume)) }}</td> | ||
| </tr> | ||
| <thead> |
There was a problem hiding this comment.
cleanup not related
janmichek
commented
Dec 13, 2024
| @@ -27,27 +27,15 @@ const chartsStore = useChartsStore() | |||
| const { hashrateStatistics } = storeToRefs(chartsStore) | |||
| const { fetchHashrateStatistics } = chartsStore | |||
|
|
|||
| const props = defineProps({ | |||
There was a problem hiding this comment.
all cleanup and lil refactoring
janmichek
commented
Dec 13, 2024
| class="transactions-panel"/> | ||
| <transactions-panel class="transactions-panel"/> | ||
| </template> | ||
| <transactions-statistics class="transactions-panel"/> |
There was a problem hiding this comment.
united with accounts now, i improved the content jumping when loading. Still, some more work to be done, but much better now.
Co-authored-by: Michele F. <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #863
Demo
Checklist: