Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dispose #4734

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Dispose #4734

wants to merge 3 commits into from

Conversation

dmarcos
Copy link
Member

@dmarcos dmarcos commented Nov 24, 2020

Just for illustration

@vincentfretin
Copy link
Contributor

I know it's for illustration purpose and the PR is quite old now, but while I'm reading really old issues, be aware that the code in this PR doesn't dispose textures. You may look at #3137 (comment) that include a link to the wiki with a better disposeNode function that close and dispose the textures.
Also with #5112 we have better handling of disposing the renderer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dmarcos @vincentfretin @kkota1