AG-13318 Fix TC9: Default enabled to true with tooltip: {}
#3405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olegat
force-pushed
the
AG-13318/qa_feedback_tc9
branch
from
2db4e4e to
0007f40
Compare
|
Snapshots automatically updated, please review before merge: diff |
|
Note Linear/Radial gauge snapshots updates are valid. (Tooltips removed from the examples) |
There was a problem hiding this comment.
Should we enable tooltips explicitly for these test cases, as it feels like we're losing some coverage otherwise?
There was a problem hiding this comment.
We could, but there's minimal gain in doing so because the tooltips that we've got on our examples are very rudimentary. It would be nice to update the docs to include prettier tooltips.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://ag-grid.atlassian.net/browse/AG-13318