Skip to content

Commit

Permalink
Correctly select the base product to install (bsc#1235931) (#1912)
Browse files Browse the repository at this point in the history
## Problem

- A different product is installed in the target system than selected
initially
- https://bugzilla.suse.com/show_bug.cgi?id=1235931

## Details

- The product was selected but later a reset was called so the selection
was lost
- Then the solver selected a random product to satisfy the dependencies

## Solution

- Just select the product later, after resetting the selection

## Testing

- Tested manually, it fixes t he problem
  • Loading branch information
jreidinger authored Jan 16, 2025
2 parents e115d21 + 693f8da commit db4e151
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 1 deletion.
4 changes: 3 additions & 1 deletion service/lib/agama/software/proposal.rb
Original file line number Diff line number Diff line change
Expand Up @@ -86,8 +86,10 @@ def set_resolvables(unique_id, type, resolvables, optional: false)
# @return [Boolean]
def calculate
initialize_target
select_base_product
@proposal = Yast::Packages.Proposal(force_reset = true, reinit = false, _simple = true)
# select the base product after running the Packages.Proposal, the force_reset = true
# option would reset the selection and a random product would be selected by the solver
select_base_product
solve_dependencies

valid?
Expand Down
5 changes: 5 additions & 0 deletions service/package/rubygem-agama-yast.changes
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
-------------------------------------------------------------------
Thu Jan 16 17:30:03 UTC 2025 - Ladislav Slezák <[email protected]>

- Correctly select the base product to install (bsc#1235931)

-------------------------------------------------------------------
Wed Jan 15 14:26:11 UTC 2025 - José Iván López González <[email protected]>

Expand Down

0 comments on commit db4e151

Please sign in to comment.