Merge master branch #1898
Merged
Merge master branch #1898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Only for testing purposes.
Actually, at this moment the flag is only used for including a link to the route in the main navigation or not depending on the Product#registration value. But the idea is to limite the navigation too in future iterations.
An initial version that basically consists on - Main menu entry for registration - Global alert visible on all pages except the registration page and those mounted at "supportive paths" (temporary name) - Section with form for entering registration code and email - Section to display registration information when available Only basic workflow has been manually tested; unit tests will be added in upcoming commits.
Certain elements must not be rendered on paths that do not use the "FullLayout". Other paths, considered "accessory" paths, have been temporarily grouped under the "SUPPORTIVE_PATHS" constant to reduce code duplication when excluding elements from them. Although the approach needs improvement, starting with the naming, let's use it where needed meanwhile.
not tested!
Otherwise, it will trigger the useProduct hook which might not be available yet like in the case of the login path, in which the QueryClient has not been initialized yet.
…ct_registrion_poc_fix
Work-around issue with suse-connect cannot read credentials file.
But not rendering the link to the registration section when the user is already there. This commit also add the missing unit tests, covering all scenarios implemented until now.
To use the proper value according to the recently updated type. Basically using "no" instead of "No".
To make them work again now that it is making use of useLocation ReactRouterDom hook and to ensure it does not try to mount ProductRegistrationAlert component at certain paths.
Agama-weblate commit: 38faf34ce34eeae7ea5174581cb00d2903c247e4
Updating the web translation files from the agama-weblate repository
Updating the service translation files from the agama-weblate repository
Update to release version 11. * #1495 * #1564 * #1617 * #1618 * #1625 * #1626 * #1627 * #1628 * #1630 * #1631 * #1632 * #1633 * #1634 * #1635 * #1636 * #1639 * #1640 * #1641 * #1642 * #1643 * #1644 * #1645 * #1646 * #1647 * #1648 * #1649 * #1650 * #1651 * #1652 * #1654 * #1655 * #1656 * #1657 * #1660 * #1663 * #1666 * #1667 * #1668 * #1670 * #1671 * #1673 * #1674 * #1675 * #1676 * #1677 * #1681 * #1682 * #1683 * #1684 * #1687 * #1688 * #1689 * #1690 * #1691 * #1692 * #1693 * #1694 * #1695 * #1696 * #1698 * #1699 * #1702 * #1703 * #1704 * #1705 * #1707 * #1708 * #1709 * #1710 * #1711 * #1712 * #1713 * #1714 * #1715 * #1716 * #1717 * #1718 * #1720 * #1721 * #1722 * #1723 * #1727 * #1728 * #1729 * #1731 * #1732 * #1733 * #1734 * #1735 * #1736 * #1737 * #1740 * #1741 * #1743 * #1744 * #1745 * #1746 * #1751 * #1753 * #1754 * #1755 * #1757 * #1762 * #1763 * #1764 * #1765 * #1766 * #1767 * #1769 * #1771 * #1772 * #1773 * #1774 * #1777 * #1778 * #1785 * #1786 * #1787 * #1788 * #1789 * #1790 * #1791 * #1792 * #1793 * #1794 * #1795 * #1796 * #1797 * #1798 * #1799 * #1800 * #1802 * #1803 * #1804 * #1805 * #1807 * #1808 * #1809 * #1810 * #1811 * #1812 * #1814 * #1815 * #1821 * #1822 * #1823 * #1824 * #1825 * #1826 * #1827 * #1828 * #1830 * #1831 * #1832 * #1833 * #1834 * #1835 * #1836 * #1837 * #1838 * #1839 * #1840 * #1841 * #1842 * #1843 * #1844 * #1845 * #1847 * #1848 * #1849 * #1850 * #1851 * #1854 * #1855 * #1856 * #1857 * #1860 * #1861 * #1863 * #1864 * #1865 * #1866 * #1867 * #1871 * #1872 * #1873 * #1875 * #1876 * #1877 * #1878 * #1880 * #1881 * #1882 * #1883 * #1884 * #1885 * #1886 * #1888 * #1889 * #1890
By limiting the render of the change product button and redirecting product selection path.
## Problem Although it is not possible to change a product after registering one, web interface still rendering the _Change product_ action and does not redirect to the root path when users try to navigates to the product selection. ## Solution Check if there is a registration code set for both, * Do not render the change product action * Navigates to root path in case the user reach the selection product path. ## Testing - Added a new unit test - Manually tested by @jreidinger --- Related to * #1891 * #1882
|
Note for review: commits before 0f83668 were already reviewed in the master branch. |
with `python -m json.tool`
## Problem When changing answers format from yaml to json example file was not converted. ## Solution Convert it and also use example which provides password.
By addressing several issues, namely
* use installerRender instead of plainRender, since the component now
uses hooks that requires the former.
* mock the ProductRegistrationAlert, to avoid the test failing because
an empty render due to a suspense derived for that component. A
better solution is needed, but out of the scope of this commit.
* use getByRole over queryByRole
Commit also drop a comment about the use of FormData API over internal
component state. The question still valid, but not needed to have a
FIXME there.
This comment was marked as outdated.
This comment was marked as outdated.
## Problem *csv* does not belong to the ruby standard library since ruby 3.4. The gem is still installed as part of the ruby 3.4 package, but the CI task for running unit tests fails because the code is executed via bundle. ## Solution Add the required gems to the gemspec file.
imobachgs
reviewed
Jan 15, 2025
imobachgs
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge master branch in order to sync the feature branch for the new storage UI.