Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(web): drop DeviceSelection #1914

Merged
merged 6 commits into from
Jan 17, 2025
Merged

fix(web): drop DeviceSelection #1914

merged 6 commits into from
Jan 17, 2025

Conversation

joseivanlopez
Copy link
Contributor

Problem

The DeviceSelection component is not used anymore and it has a lot of code.

Solution

Remove DeviceSelection and all the code associated to it.

@joseivanlopez joseivanlopez changed the base branch from master to storage-config-ui January 17, 2025 09:47
@joseivanlopez joseivanlopez marked this pull request as ready for review January 17, 2025 09:47
@coveralls
Copy link

coveralls commented Jan 17, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 12826606039

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.006%) to 72.51%
Files with Coverage Reduction New Missed Lines %
rust/agama-server/src/web/ws.rs 1 0.0%
rust/agama-server/src/web.rs 2 0.0%
Totals Coverage Status
Change from base Build 12826538658: -0.006%
Covered Lines: 18939
Relevant Lines: 26119
💛 - Coveralls

@joseivanlopez joseivanlopez merged commit 3a3e0a2 into agama-project:storage-config-ui Jan 17, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgdavid dgdavid dgdavid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joseivanlopez @coveralls @dgdavid