Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed icewm configuration using setup from yast #1931

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fixed icewm configuration using setup from yast #1931

wants to merge 3 commits into from

Conversation

mchf
Copy link
Contributor

@mchf mchf commented Jan 22, 2025 •
edited
Loading

Problem

In running Agama installer user was able to open IceWM's main menu using Win key

Solution

Taken preferences.yast2 from yast-theme package

Note: the Makefile patch was taken from @lslezak https://github.com/agama-project/agama/compare/efi_locale?expand=1#diff-3814de00178ccbebe225da81ee5f56663518b579103d005782925a8b014491ca

Testing

  • Tested manually

@mchf mchf requested a review from imobachgs January 22, 2025 09:52
@coveralls
Copy link

coveralls commented Jan 22, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 12905607943

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 70.854%
Files with Coverage Reduction New Missed Lines %
rust/agama-server/tests/common/mod.rs 5 74.19%
Totals Coverage Status
Change from base Build 12894451227: -0.02%
Covered Lines: 17241
Relevant Lines: 24333
💛 - Coveralls

imobachgs
imobachgs approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@imobachgs imobachgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, do not merge yet until beta 1 is released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imobachgs imobachgs imobachgs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mchf @coveralls @imobachgs