Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web): show a welcome screen #1941

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

feat(web): show a welcome screen #1941

wants to merge 3 commits into from

Conversation

dgdavid
Copy link
Contributor

@dgdavid dgdavid commented Jan 24, 2025

Problem

There is not a way for users for easily changing their preferred language even when they know nothing about English.

https://trello.com/c/FS1zHTuL/4061-3-agama-create-a-welcome-screen

Solution

To start with a quite simple welcome screen displaying a list of available languages.

Copy link
Contributor Author

@dgdavid dgdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still in progress, since there are some drawbacks with the current approach of refreshing the whole interface after requesting the selected language.

  • Welcome screen UI cannot react to the selected language for translating the text in the screen and, more important, the main action. Something Agama can live with for the first iteration, though.
  • It leads to see too much loader flash (at least four, IIRC) plus an additional flash of the welcome screen, which has to wait until configuration is applied for navigating ahead
  • There is also something wrong that makes the installer get stuck in a loader instead of reaching the product selection page.
  • From the welcome screen it is (or it shouldn't be) possible to setup the language for the selected product, because there is not a selected product yet. An idea from @imobachgs is to set the language for the product according to the installer settings after selecting the product. However, I think would be nice to be able to send some "default settings" for the product when selecting it instead of waiting after the product selection is finished for requesting something else automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant