-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: prevent reaching the congratulations screen during installation #1942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imobachgs
force-pushed
the
finish-phase
branch
from
January 24, 2025 09:46
926187e
to
cdcfb3d
Compare
imobachgs
force-pushed
the
finish-phase
branch
from
January 24, 2025 10:00
cdcfb3d
to
1d6e534
Compare
Pull Request Test Coverage Report for Build 12947364045Details
💛 - Coveralls |
imobachgs
force-pushed
the
finish-phase
branch
from
January 24, 2025 10:49
1d6e534
to
aed0915
Compare
imobachgs
changed the title
fix: avoid reaching the congratulations screen during installation
fix: prevent reaching the congratulations screen during installation
Jan 24, 2025
imobachgs
force-pushed
the
finish-phase
branch
from
January 24, 2025 11:07
aed0915
to
56eadf1
Compare
jreidinger
reviewed
Jan 24, 2025
jreidinger
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Agama determines in which point of the installation it is by the combination of two values: the
installation phase (startup, config and install) and the isBusy flag. This method has proven to be
rather fragile.
One of the typical issues is jumping into the "congratulations" screen
when the installation is not even finished. See #1616.
Although we mitigated this problem, it recently appear in our QA testing.
Solution
Let's introduce a new phase, "finish", which indicates that the installation is finished. As simple
as that. So we do not need a combination of two values anymore at that point. We plan to extend this
approach to other parts.
Testing
Related to https://trello.com/c/UmVLEYxE (internal link)