Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent reaching the congratulations screen during installation #1942

Merged
merged 5 commits into from
Jan 24, 2025

Conversation

imobachgs
Copy link
Contributor

@imobachgs imobachgs commented Jan 24, 2025

Problem

Agama determines in which point of the installation it is by the combination of two values: the
installation phase (startup, config and install) and the isBusy flag. This method has proven to be
rather fragile.

One of the typical issues is jumping into the "congratulations" screen
when the installation is not even finished. See #1616.

Although we mitigated this problem, it recently appear in our QA testing.

Solution

Let's introduce a new phase, "finish", which indicates that the installation is finished. As simple
as that. So we do not need a combination of two values anymore at that point. We plan to extend this
approach to other parts.

Testing

  • Added a new unit test
  • Tested manually

Related to https://trello.com/c/UmVLEYxE (internal link)

@coveralls
Copy link

coveralls commented Jan 24, 2025

Pull Request Test Coverage Report for Build 12947364045

Details

  • 8 of 9 (88.89%) changed or added relevant lines in 3 files are covered.
  • 20 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.02%) to 70.911%

Changes Missing Coverage Covered Lines Changed/Added Lines %
rust/agama-lib/src/manager.rs 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
rust/agama-lib/src/manager.rs 1 0.0%
service/lib/agama/dbus/manager.rb 6 92.31%
service/lib/agama/manager.rb 13 80.99%
Totals Coverage Status
Change from base Build 12946688667: 0.02%
Covered Lines: 17264
Relevant Lines: 24346

💛 - Coveralls

@imobachgs imobachgs changed the title fix: avoid reaching the congratulations screen during installation fix: prevent reaching the congratulations screen during installation Jan 24, 2025
@imobachgs imobachgs marked this pull request as ready for review January 24, 2025 11:22
dgdavid

This comment was marked as outdated.

@imobachgs imobachgs merged commit c17204c into master Jan 24, 2025
10 checks passed
@imobachgs imobachgs deleted the finish-phase branch January 24, 2025 12:44
@dgdavid
Copy link
Contributor

dgdavid commented Jan 24, 2025

For the record, by adding the FINISHED installation phase, this finally solves (in a more robust way) the problem previously reported at #1616 and mitigated at #1690.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants