Install dir #1959
Merged
Install dir #1959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lslezak
approved these changes
Jan 29, 2025
| # path to cdrom which can contain installation repositories | ||
| dir_path = "/run/initramfs/live/install" | ||
|
|
||
| if File.exist?(dir_path) |
There was a problem hiding this comment.
Just nit-picking, I'd reverse the logic:
return false unless File.exist?(dir_path)
logger.info "/install found on installation medium"
repositories.add("dir://" + dir_path)
trueThis avoids using an indented block.
There was a problem hiding this comment.
Yes, searching for a dir should be faster.
There was a problem hiding this comment.
@kobliha I think you mean change of order of checking for dir versus label?
There was a problem hiding this comment.
I do not think it will make difference and lets merge this one for now to have something working
lslezak
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
For full offline medium support we need to check also if there is repositories in
/installon medium.Solution
Add support to detect it and use it if found.
Note: live
/is not the one from iso, so it needs to check mounted initramfsTesting