Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web): set mutations network mode to "always" #1963

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

imobachgs
Copy link
Contributor

@imobachgs imobachgs commented Jan 31, 2025

Problem

The web UI does not perform any mutation when the network gets disconnected.

Solution

Set the network mode to always for mutations, as they have a separate set of default options from queries. This change is analogous to what we did in #1909 for queries.

Testing

  • Tested manually

@imobachgs imobachgs force-pushed the mutations-network-mode branch from db054e5 to 2ba79b9 Compare January 31, 2025 09:00
@imobachgs
Copy link
Contributor Author

It should fix #1963.

Copy link
Contributor

@dgdavid dgdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this @imobachgs 🚀

@dgdavid
Copy link
Contributor

dgdavid commented Jan 31, 2025

It should fix #1963.

You mean #1962, right?

@imobachgs
Copy link
Contributor Author

It should fix #1963.

You mean #1962, right?

Ouch, yes, you are right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants