fix review comments

aganesh-suse · Apr 5, 2024 · d8c9f37 · d8c9f37
1 parent 903c9a7
commit d8c9f37
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/pkg/testcase/secretsencrypt.go b/pkg/testcase/secretsencrypt.go
@@ -21,7 +21,7 @@ func TestSecretsEncryption() {
 
 	ips := getNodeIps(nodes)
 
-	errSecret := shared.CreateSecret("secret1", "default")
+	errSecret := shared.CreateSecret("secret1", "default", false)
 	Expect(errSecret).NotTo(HaveOccurred(), "error creating secret")
 
 	shared.LogLevel("INFO", "TEST: 'CLASSIC' Secrets Encryption method")

diff --git a/shared/cluster.go b/shared/cluster.go
@@ -634,7 +634,7 @@ func FetchToken(ip string) (string, error) {
 	return token, nil
 }
 
-func CreateSecret(secret, namespace string) error {
+func CreateSecret(secret, namespace string, print bool) error {
 	kubectl := fmt.Sprintf("kubectl --kubeconfig %s", KubeConfigFile)
 	if namespace == "" {
 		namespace = "default"
@@ -648,7 +648,9 @@ func CreateSecret(secret, namespace string) error {
 	if strings.Contains(createStdOut, "failed to create secret") {
 		return ReturnLogError("failed to create secret: \n%w", err)
 	}
-	LogLevel("DEBUG", "Create Secret Output: %s", createStdOut)
+	if print {
+		LogLevel("DEBUG", "Create Secret Output: %s", createStdOut)
+	}
 	return nil
 }