Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extremal Morphisms #340

Merged
merged 9 commits into from
Mar 18, 2022
Merged

Extremal Morphisms #340

merged 9 commits into from
Mar 18, 2022

Conversation

TOTBWF
Copy link
Collaborator

@TOTBWF TOTBWF commented Mar 13, 2022

Patch Description

This PR implements Extremal Morphisms, and proves some properties about them. It also proves some helper lemmas about epis/monos, and performs some minor cleanup of equalizers + coequalizers.

Notes

The names of the morphisms in RegularMono/RegularEpi are really annoying... Perhaps there's a better choice instead of g and h?

Copy link
Collaborator

@JacquesCarette JacquesCarette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

A couple of minor things (no need to change for this PR):

  • it really is best to use using as much as possible on all open import
  • I really would have preferred 2 PRs, one for the clean-up, and one for the new functionality.

@JacquesCarette
Copy link
Collaborator

Can you open an issue about the naming of the fields in RegularMono / RegularEpi ? I agree that these names are too short and not meaningful. But I'd like more people to have a chance to comment. Might be good to see what other libraries use for these names (i.e. outside the Agda ecosystem).

@TOTBWF
Copy link
Collaborator Author

TOTBWF commented Mar 14, 2022

Opened #341 to track the naming issue. I'll leave this up for a few days to get feedback, but if no one has anything to say I think we should be good to merge :)

@TOTBWF TOTBWF merged commit 7038209 into agda:master Mar 18, 2022
@TOTBWF TOTBWF deleted the extremal-morphisms branch March 18, 2022 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants