Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open subschemes #1096

Merged
merged 37 commits into from
Mar 16, 2024
Merged

Open subschemes #1096

merged 37 commits into from
Mar 16, 2024

Conversation

mzeuner
Copy link
Contributor

@mzeuner mzeuner commented Feb 1, 2024

This builds on (#1082) and (#1086),
but even with those two merged it is still a long one, my apologies...

The PR contains the following:

  • definition of standard (compact) open subfunctors of an affine scheme and proof that those are affine
  • proof that any compact open subfunctor of an affine scheme is a qcqs-scheme

The file Cubical.Categories.Instances.ZFunctors has gotten quite big and type-checking it is starting to get slow.
Ultimately, I think it should be split up into several files in a separate (functorial) AlgebraicGeometry directory,
see this issue: #1095
I'm postponing this for a separate PR though

@MatthiasHu
Copy link
Contributor

@mzeuner Could you try to resolve the merge conflicts here or would you like me to do it?

@mzeuner mzeuner force-pushed the OpenSubschemes branch 2 times, most recently from 6c7fb31 to 1a2c6f3 Compare February 26, 2024 15:51
@mzeuner
Copy link
Contributor Author

mzeuner commented Feb 26, 2024

@mzeuner Could you try to resolve the merge conflicts here or would you like me to do it?

This was harder than I expected, but now it should work...

@MatthiasHu
Copy link
Contributor

In the future, it might be good to move the definition of support maps and related lemmas (currently in ZariskiLattice.UniversalProperty) to a separate file, since it does not depend on the Zariski lattice. But perhaps not in this PR. (Just discussed with @mzeuner .)

manually cherry-picked from 93d52b5
manually cherry-picked from 73cc74a
manually cherry-picked from 2c4d6d1
manually cherry-picked from d41b178
@felixwellen
Copy link
Collaborator

Is this PR intentionally open?

@felixwellen
Copy link
Collaborator

The PR contains the following:

* definition of standard (compact) open subfunctors of an affine scheme and proof that those are affine

* proof that any compact open subfunctor of an affine scheme is a qcqs-scheme

Do you have a reason for not putting these two (or maybe three?) points in different PRs?

@MatthiasHu MatthiasHu self-assigned this Feb 27, 2024
@MatthiasHu
Copy link
Contributor

Is this PR intentionally open?

Yes, @mzeuner and I discussed it a bit today and I am working on reviewing it.

@felixwellen
Copy link
Collaborator

Is this PR intentionally open?

Yes, @mzeuner and I discussed it a bit today and I am working on reviewing it.

Good - then I'll leave you to it.

Comment on lines +110 to +116
module JoinMap {L : DistLattice ℓ} {L' : DistLattice ℓ'} (φ : DistLatticeHom L L') where
private module L = Join L
private module L' = Join L'
open BigOpMap (LatticeHom→JoinSemilatticeHom φ)

pres⋁ : {n : ℕ} (U : FinVec ⟨ L ⟩ n) → φ .fst (L.⋁ U) ≡ L'.⋁ (φ .fst ∘ U)
pres⋁ = presBigOp
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems weird to have this lemma only for Join and not for Meet. But this was already the case for other definitions in this file (and I find it pretty hard to see which ones)...

I guess this is part of the general question how to handle the duality between join and meet nicely.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the analogous case for meets of this one: ef4ae22

I did treat meets and joins symmetrically, but I never ended up using big meets, so a bunch of lemmas are only done for big joins. After all, they are what you need to define a "cover", so arguably the more useful one...

@felixwellen felixwellen self-assigned this Mar 16, 2024
@felixwellen
Copy link
Collaborator

ZFunctors should definitely be split up - no need to do it in this PR though.
Otherwise it looks good to me and it still checks on current master -> merging.

@felixwellen felixwellen merged commit 8dc7788 into agda:master Mar 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants