-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open subschemes #1096
Open subschemes #1096
Conversation
@mzeuner Could you try to resolve the merge conflicts here or would you like me to do it? |
6c7fb31
to
1a2c6f3
Compare
(with Max Zeuner)
1a2c6f3
to
e582d07
Compare
This was harder than I expected, but now it should work... |
In the future, it might be good to move the definition of support maps and related lemmas (currently in |
Is this PR intentionally open? |
Do you have a reason for not putting these two (or maybe three?) points in different PRs? |
Yes, @mzeuner and I discussed it a bit today and I am working on reviewing it. |
Good - then I'll leave you to it. |
module JoinMap {L : DistLattice ℓ} {L' : DistLattice ℓ'} (φ : DistLatticeHom L L') where | ||
private module L = Join L | ||
private module L' = Join L' | ||
open BigOpMap (LatticeHom→JoinSemilatticeHom φ) | ||
|
||
pres⋁ : {n : ℕ} (U : FinVec ⟨ L ⟩ n) → φ .fst (L.⋁ U) ≡ L'.⋁ (φ .fst ∘ U) | ||
pres⋁ = presBigOp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems weird to have this lemma only for Join
and not for Meet
. But this was already the case for other definitions in this file (and I find it pretty hard to see which ones)...
I guess this is part of the general question how to handle the duality between join and meet nicely.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added the analogous case for meets of this one: ef4ae22
I did treat meets and joins symmetrically, but I never ended up using big meets, so a bunch of lemmas are only done for big joins. After all, they are what you need to define a "cover", so arguably the more useful one...
ZFunctors should definitely be split up - no need to do it in this PR though. |
This builds on (#1082) and (#1086),
but even with those two merged it is still a long one, my apologies...
The PR contains the following:
The file
Cubical.Categories.Instances.ZFunctors
has gotten quite big and type-checking it is starting to get slow.Ultimately, I think it should be split up into several files in a separate (functorial)
AlgebraicGeometry
directory,see this issue: #1095
I'm postponing this for a separate PR though