-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wtforms widgets #494
Merged
Merged
Wtforms widgets #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d3f0f57
to
75e1362
Compare
I've check all forms except the However, the I've also noted some things that should be adjusted / fixed in some forms, unrelated to the introduction of wtforms. Do you think these should be approached in this PR? |
d563b43
to
130e7cf
Compare
313257a
to
6ecebdb
Compare
* Replace Facebook with Instagram * GitHub: Link organisation instead of this project
The implicit assumption in wtforms_widgets is to leave a 4fr (of 12fr) gap to the right of the form. That needs to be fixed.
I don't think we should do this in the template.
6ecebdb
to
484af83
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #493
TODO