Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complex number support #249

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

chillenb
Copy link

@chillenb chillenb commented Nov 17, 2024

Changes

Fixes #248

Adds support for complex numbers under tag 43000.

Checklist

If this is a user-facing code change, like a bugfix or a new feature, please ensure that
you've fulfilled the following conditions (where applicable):

  • You've added tests (in tests/) added which would fail without your patch
  • You've updated the documentation (in docs/, in case of behavior changes or new
    features)
  • You've added a new changelog entry (in docs/versionhistory.rst).

If this is a trivial change, like a typo fix or a code reformatting, then you can ignore
these instructions.

Updating the changelog

If there are no entries after the last release, use **UNRELEASED** as the version.
If, say, your patch fixes issue #999, the entry should look like this:

- Fixed big bad boo-boo in the encoder (#999 <https://github.com/agronholm/cbor2/issues/999>_; PR by @yourgithubaccount)

If there's no issue linked, just link to your pull request instead by updating the
changelog after you've created the PR.

@chillenb chillenb force-pushed the complex branch 3 times, most recently from d775279 to 3ff08b3 Compare November 17, 2024 22:53
@coveralls
Copy link

Coverage Status

coverage: 93.248% (-0.3%) from 93.542%
when pulling 1c4da62 on chillenb:complex
into d9cee77 on agronholm:master.

@chillenb
Copy link
Author

Not sure what's happening with the fuzzer. It doesn't look like it ran properly?

@agronholm
Copy link
Owner

Not sure what's happening with the fuzzer. It doesn't look like it ran properly?

Don't worry about that. It never worked right, and I haven't been able to reach the person who added it. I haven't decided what to do about it yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Complex numbers!
3 participants