Fix filter

ahobsonsayers · Sep 27, 2024 · 6b47a79 · 6b47a79
1 parent 73f062f
commit 6b47a79
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 3 deletions.
diff --git a/twickets/filter.go b/twickets/filter.go
@@ -87,8 +87,8 @@ func filterToNumTickets(tickets Tickets, numTickets int) Tickets {
 	return tickets
 }
 
-func filterToCreatedAfter(tickets Tickets, createdAfter time.Time) Tickets {
-	if createdAfter.IsZero() {
+func FilterTicketsCreatedAfter(tickets Tickets, createdAfter time.Time) Tickets {
+	if !createdAfter.IsZero() {
 		filteredTickets := make(Tickets, 0, len(tickets))
 		for _, ticket := range tickets {
 			if ticket.CreatedAt.Time.After(createdAfter) {

diff --git a/twickets/filter_test.go b/twickets/filter_test.go
@@ -2,6 +2,7 @@ package twickets_test
 
 import (
 	"testing"
+	"time"
 
 	"github.com/ahobsonsayers/twitchets/twickets"
 	"github.com/stretchr/testify/require"
@@ -56,3 +57,20 @@ func TestFilterName(t *testing.T) {
 	}})
 	require.Empty(t, filteredTickets)
 }
+
+func TestFilterTicketsToCreatedAfter(t *testing.T) {
+	currentTime := time.Now()
+	tickets := twickets.Tickets{
+		{CreatedAt: twickets.UnixTime{currentTime.Add(-1 * time.Minute)}},
+		{CreatedAt: twickets.UnixTime{currentTime.Add(-2 * time.Minute)}},
+		{CreatedAt: twickets.UnixTime{currentTime.Add(-4 * time.Minute)}},
+		{CreatedAt: twickets.UnixTime{currentTime.Add(-5 * time.Minute)}},
+	}
+
+	filteredTickets := twickets.FilterTicketsCreatedAfter(
+		tickets,
+		currentTime.Add(-3*time.Minute),
+	)
+
+	require.Equal(t, tickets[0:2], filteredTickets)
+}
diff --git a/twickets/twickets.go b/twickets/twickets.go
@@ -126,7 +126,7 @@ func (c *Client) FetchTickets(ctx context.Context, input FetchTicketsInput) (Tic
 
 	// Only return tickets requested
 	tickets = filterToNumTickets(tickets, input.NumTickets)
-	tickets = filterToCreatedAfter(tickets, input.CreatedAfter)
+	tickets = FilterTicketsCreatedAfter(tickets, input.CreatedAfter)
 
 	return tickets, nil
 }