Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP - Adding mention user support in issue comments #360

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

djgoku
Copy link
Contributor

@djgoku djgoku commented Sep 29, 2024

This is feature complete, but I want to do more testing. I'll also break up the commits once it is closer to merging.

Also there was a type bug (should be boolean and not a string) in the org-jira-update-issues-details-include-reporter variable I added.

@ahungry While testing this (new Jira Cloud account) I had to conditionally disable updating issue details for components and priority. I can't say I like this, but haven't really thought of a better way to implement this.

Features:

  • Comments are now written in a buffer. You can mention users by calling M-x org-jira-mention-user (not sure if there is more we can do here).
  • PROJECT.org where all PROJECT issues are saved. Issue comments now show display name over [~accountid:8675309].

Implements #254 #221

Screenshot 2024-09-29 at 13 47 39
Screenshot 2024-09-29 at 13 47 12

This is feature complete in my books, but I'll be testing it for a
week or more before PRing.
@djgoku djgoku changed the title WIP - Adding jira mention user in issue comments WIP - Adding mention user support in issue comments Sep 29, 2024
@ahungry
Copy link
Owner

ahungry commented Oct 1, 2024

Nice! Maybe some people could try this out pre-merge and give a thumbs up if it seems non-impactful to their existing workflows / new features seem to operate without any hiccups.

@dhruvasagar
Copy link

I tried to get it working but I it didn't work for me. The function org-jira-mention-user gave an error about jira-project

@dhruvasagar
Copy link

This would be really nice to have

@djgoku
Copy link
Contributor Author

djgoku commented Nov 14, 2024

I tried to get it working but I it didn't work for me. The function org-jira-mention-user gave an error about jira-project

Would you be able to share the whole error?

I have been meaning to comeback to finishing this PR. The interface should not change much, but I am re-working it and adding as much testing as I can before PRing it.

@dhruvasagar
Copy link

@djgoku I get this error when invoking org-jira-mention-user funcall-interactively: Symbol’s value as variable is void: jira-project

@dhruvasagar
Copy link

@djgoku any update on this ? Are you planning on working on this ?

@djgoku
Copy link
Contributor Author

djgoku commented Feb 7, 2025

Yes! I should have sometime this weekend to work on this. @dhruvasagar Thanks for the nudge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants