New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some minor cleanups following #308 #310

Open

spencerkclark wants to merge 2 commits into master from cleanup

Member

spencerkclark commented Jun 29, 2022 •

edited

Loading

In porting the changes in #308 to SHiELD, I noticed a few areas where things could be cleaned up:

Within the code to coarse-grain tracer fields on surfaces of constant pressure, we can remove the need to look up the tracer name within the prognostic tracer loop since we no longer need to distinguish between the weights for the cloud fraction and hydrometeor tracers.
Within the code to coarse-grain diagnostics we can make the subroutines for determining whether we need to allocate memory for masked area or mass arrays more readable.

These changes do not change the behavior or answers in any way.

spencerkclark added 2 commits

June 29, 2022 13:02


          Remove now unneeded call to get tracer name

70b4014


          Clean up code to determine whether we need mass or masked area arrays

167840d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet