Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue1173: Fix Parameter Order for MergeAndShrinkAlgorithm #248

Merged
merged 3 commits into from
Feb 7, 2025

Conversation

speckdavid
Copy link
Contributor

This is the PR to fix issue.

We (Simon and I) found a bug in the parameter order for constructing the M&S
algorithm inside of the constructor of MergeAndShrinkHeuristic, which sets the
transition system sizes to wrong values. This is because the expected order is bool
prune_unreachable_states, bool prune_irrelevant_states, int max_states, int
max_states_before_merge, int threshold_before_merge. However, the current order is
int max_states, int max_states_before_merge, int threshold_before_merge, bool
prune_unreachable_states, bool prune_irrelevant_states. For example, this sets the
value for max_states to zero or one because the boolean prune_unreachable_state is
passed.

This also occurs in the latest release, which may give a reason to update it.

@speckdavid speckdavid changed the title Issue1173 Issue1173: Fixed Parameter Order for MergeAndShrinkAlgorithm Feb 6, 2025
@speckdavid speckdavid changed the title Issue1173: Fixed Parameter Order for MergeAndShrinkAlgorithm Issue1173: Fix Parameter Order for MergeAndShrinkAlgorithm Feb 6, 2025
@speckdavid speckdavid requested a review from SimonDold February 7, 2025 09:53
@maltehelmert maltehelmert merged commit 6a363d0 into aibasel:main Feb 7, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants