Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[issue1173] fix parameter order for MergeAndShrinkAlgorithm. #249

Merged
merged 3 commits into from
Feb 7, 2025

Conversation

speckdavid
Copy link
Contributor

We passed the options for the merge_and_shrink evaluator into the constructor
of an internal class in the wrong order, leading to wrong behaviour. For example,
the boolean option prune_unreachable_states was interpreted as max_states,
so that max_states was set to 0 or 1 based on the boolean flag. This is now fixed.

@maltehelmert maltehelmert merged commit cb07083 into aibasel:main Feb 7, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants