feat: update translators to include new trajectory msgs #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@domire8 tagging you here although this is still WIP just for your information. It won't build since we are relying on unmerged/unreleased |
bpapaspyros
commented
Feb 12, 2025
| seconds=state.get_time_from_start(i).total_seconds()).to_msg() | ||
| message.points.append(ros_point) | ||
| message.header.frame_id = state.get_name() | ||
| # todo: should we properly stamp it? |
There was a problem hiding this comment.
note to self and others: we need to discuss this
Yes this is relevant, we need to see how to create pre release version of control libraries with the CI over there |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR solves the issue by adding new readers/writers for python and C++ including translations from
trajectory_msgs/JointTrajectory. It also adds tests to verify the functionality of the newstate_representationclasses within modulo.Review guidelines
Estimated Time of Review: 15 minutes
Checklist before merging: