Use tmpdir for povray rendering #675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #675 +/- ##
==========================================
+ Coverage 83.33% 83.37% +0.03%
==========================================
Files 17 17
Lines 3583 3591 +8
==========================================
+ Hits 2986 2994 +8
Misses 597 597
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
superstar54
reviewed
Feb 6, 2025
| @@ -107,6 +109,10 @@ def test_structure_data_viewer_storage(structure_data_object): | |||
| # fmt: on | |||
| v._render_structure() | |||
|
|
|||
| # Make sure we don't polute current working dir with tempfiles | |||
There was a problem hiding this comment.
Thanks for the fix, but is this necessary for the test to pass? If it pollutes the working dir, will the test fail?
There was a problem hiding this comment.
Yes, it's a regression test for this PR.
danielhollas
force-pushed
the
use-tmp-dir
branch
from
03525ce to
d06764a
Compare
|
@superstar54 I've rebased this branch to get rid of the unrelated changes, please take a look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on top of #627 which needs to be merged first.Fixes #676