Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ipython as a direct dependency #678

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

danielhollas
Copy link
Contributor

We import from ipython directly in a bunch of places (e.g. from IPython.display import Javascript, display) so we should declare it as a direct dependency.

I've determined the minimum version by looking at a version in a very old aiidalab image.

docker run docker.io/aiidalab/full-stack:aiida-2.1.2 pip show ipython

Part of #392

Copy link
Member

@superstar54 superstar54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.37%. Comparing base (c63293f) to head (acb99b4).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #678   +/-   ##
=======================================
  Coverage   83.37%   83.37%           
=======================================
  Files          17       17           
  Lines        3591     3591           
=======================================
  Hits         2994     2994           
  Misses        597      597           
Flag Coverage Δ
python-3.11 83.37% <ø> (ø)
python-3.9 83.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielhollas danielhollas merged commit 5af54cd into aiidalab:master Feb 6, 2025
11 checks passed
@danielhollas danielhollas deleted the ipython-dep branch February 6, 2025 20:18
Copy link
Member

@edan-bainglass edan-bainglass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍

@danielhollas danielhollas added the dependencies Pull requests that update a dependency file label Feb 7, 2025
@danielhollas danielhollas self-assigned this Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants