Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MACE potential #143

Merged
merged 6 commits into from
Sep 12, 2024
Merged

Add MACE potential #143

merged 6 commits into from
Sep 12, 2024

Conversation

mankoNm
Copy link
Contributor

@mankoNm mankoNm commented Jul 12, 2024

Add the possibility to work with binary potentials.

Copy link

codecov bot commented Jul 12, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 85.41%. Comparing base (65e1bb4) to head (2e2415d).
Report is 24 commits behind head on master.

Files with missing lines Patch % Lines
src/aiida_lammps/parsers/inputfile.py 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #143      +/-   ##
==========================================
- Coverage   85.49%   85.41%   -0.08%     
==========================================
  Files          19       19              
  Lines        1620     1625       +5     
==========================================
+ Hits         1385     1388       +3     
- Misses        235      237       +2     
Flag Coverage Δ
pytests 85.41% <71.42%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@JPchico JPchico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mankoNm This looks good!
One question, do you think it would be possible to add a test?
Another thing, I see that the documentation is failing, does the same happen when you try running the pipeline locally?

@mankoNm
Copy link
Contributor Author

mankoNm commented Jul 25, 2024

@mankoNm This looks good!
One question, do you think it would be possible to add a test?
Another thing, I see that the documentation is failing, does the same happen when you try running the pipeline locally?

I have encountered the same issues with the documentation failing when running the pipeline locally. Unfortunately, I am not very familiar with the documentation setup and am having trouble identifying the cause of these failures.

Regarding the tests, I believe adding a test might not be necessary at this point because my changes are mainly aimed at ensuring the code can handle potentials in binary format. I have not altered any logic that would require new tests at this time.

If you have any specific suggestions or guidance on troubleshooting the documentation errors, I would greatly appreciate it.

@JPchico
Copy link
Collaborator

JPchico commented Aug 26, 2024

@mankoNm Sorry for the late reply I was on holidays.

I think I know why the documentation is failing and I should be able to fix it, I think it is a setting in which warnings are causing the build to fail. I will make a PR to fix it.

Regarding the tests, I believe adding a test might not be necessary at this point because my changes are mainly aimed at ensuring the code can handle potentials in binary format. I have not altered any logic that would require new tests at this time.

Fair enough, it everything works I think that is good.

I'll make the PR to fix the documentation and then merge your PR if that is okay. I will try to do it today.

@mankoNm
Copy link
Contributor Author

mankoNm commented Sep 2, 2024

@mankoNm Sorry for the late reply I was on holidays.

I think I know why the documentation is failing and I should be able to fix it, I think it is a setting in which warnings are causing the build to fail. I will make a PR to fix it.

Regarding the tests, I believe adding a test might not be necessary at this point because my changes are mainly aimed at ensuring the code can handle potentials in binary format. I have not altered any logic that would require new tests at this time.

Fair enough, it everything works I think that is good.

I'll make the PR to fix the documentation and then merge your PR if that is okay. I will try to do it today.

Dear @JPchico

Sorry for the late reply I also was on holidays :)
For me it sounds good.

Copy link
Collaborator

@JPchico JPchico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @mankoNm sorry for the long delay again, it was a kinda crazy week. I have fixed the problem with the documentation as you see so all tests are passing.

I noticed that you also added the atom_modify command, this is quite nice. I will approve as it is now, and if you have other features that you want to add please feel free to make other PRs.

@JPchico JPchico merged commit ec8583d into aiidaplugins:master Sep 12, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants