-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MACE potential #143
Add MACE potential #143
Conversation
for more information, see https://pre-commit.ci
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #143 +/- ##
==========================================
- Coverage 85.49% 85.41% -0.08%
==========================================
Files 19 19
Lines 1620 1625 +5
==========================================
+ Hits 1385 1388 +3
- Misses 235 237 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mankoNm This looks good!
One question, do you think it would be possible to add a test?
Another thing, I see that the documentation is failing, does the same happen when you try running the pipeline locally?
I have encountered the same issues with the documentation failing when running the pipeline locally. Unfortunately, I am not very familiar with the documentation setup and am having trouble identifying the cause of these failures. Regarding the tests, I believe adding a test might not be necessary at this point because my changes are mainly aimed at ensuring the code can handle potentials in binary format. I have not altered any logic that would require new tests at this time. If you have any specific suggestions or guidance on troubleshooting the documentation errors, I would greatly appreciate it. |
@mankoNm Sorry for the late reply I was on holidays. I think I know why the documentation is failing and I should be able to fix it, I think it is a setting in which warnings are causing the build to fail. I will make a PR to fix it.
Fair enough, it everything works I think that is good. I'll make the PR to fix the documentation and then merge your PR if that is okay. I will try to do it today. |
Dear @JPchico Sorry for the late reply I also was on holidays :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @mankoNm sorry for the long delay again, it was a kinda crazy week. I have fixed the problem with the documentation as you see so all tests are passing.
I noticed that you also added the atom_modify command, this is quite nice. I will approve as it is now, and if you have other features that you want to add please feel free to make other PRs.
Add the possibility to work with binary potentials.