Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: add integration test running main workflow #72

Merged
merged 6 commits into from
Feb 14, 2025
Merged

Conversation

bastonero
Copy link
Collaborator

Add integration test on real run of the main self-consistent workflow to keep track of possible issues arising from both aiida-core, or related python packages, and Quantum ESPRESSO itself, which might apply sudden changes that we cannot account for in the unit testing suite.

Add integration test on real run of the main self-consistent workflow
to keep track of possible issues arising from both aiida-core, or
related python packages, and Quantum ESPRESSO itself, which
might apply sudden changes that we cannot account for in the
unit testing suite.
Copy link
Member

@superstar54 superstar54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a few suggestions.
Overall LGTM!

Copy link
Member

@superstar54 superstar54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bastonero bastonero merged commit 6e7c540 into master Feb 14, 2025
8 checks passed
@bastonero bastonero deleted the ci-integration branch February 14, 2025 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants