Remove python2 support #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
March 6, 2020 18:12
Also remove unnecessary shebangs in module files -- these can not be executed directly.
Inside the contextmanager, tempfile.TemporaryDirectory yields only the string with the directory's name
giovannipizzi
requested changes
Mar 6, 2020
tests/calculations/test_example.py
Outdated
| spec = importlib.util.spec_from_file_location(module_name, full_path) | ||
| module = importlib.util.module_from_spec(spec) | ||
| spec.loader.exec_module(module) | ||
| import importlib.util # pylint: disable=import-error |
There was a problem hiding this comment.
Probably we don't need this disable anymore (this was to avoid that the py2 pylint complained)
There was a problem hiding this comment.
True! Funny that pylint didn't throw a useless-suppression, though.
There was a problem hiding this comment.
interesting - I never saw this message!
giovannipizzi
approved these changes
Mar 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #93
Removes the obvious ways in which python2 support was maintained, and explicitly changes the required / supported Python versions in the setup and on Travis.