Fixed hyphen in filename breaking LSP #988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MicroProofs
approved these changes
Jul 31, 2024
KtorZ
reviewed
Aug 1, 2024
There was a problem hiding this comment.
I know the testing on the LSP part is rather low, but I feel it's a good time to add the first bits of unit tests. The uri_to_module_name function should be easy to cover and ensure it matches whatever strategy we use in for aiken-project
We use a regular expression in one place ( https://github.com/aiken-lang/aiken/blob/main/crates/aiken-project/src/lib.rs#L947-L962 ), and some string transformation in the other. I am not convinced that they actually match.
|
@KtorZ mind if I merge these changes and allow him to follow up with that on a second PR? |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Really small change.