Allow pattern-matching on bytearrays #991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KtorZ
commented
Aug 2, 2024
Comment on lines
+6676
to
+6669
| // Not sure what this extra lambda is or do? | ||
| .lambda("???") | ||
| .apply(Term::Error.delay()); |
There was a problem hiding this comment.
@MicroProofs any idea what this extra lambda is? The generatd name don't even seem to be valid UTF-8 sequence or just some plain newline 🤨. It gets eventually eliminated by the optimizer, but I couldn't make sense of what it is.
KtorZ
force-pushed
the
pattern-match-bytearrays
branch
4 times, most recently
from
66e42c3
to
85094f7
Compare
- Doesn't allow pattern-matching on G1/G2 elements and strings,
because the use cases for those is unclear and it adds complexity to
the feature.
- We still _parse_ patterns on G1/G2 elements and strings, but emit an
error in those cases.
- The syntax is the same as for bytearray literals (i.e. supports hex,
utf-8 strings or plain arrays of bytes).
KtorZ
force-pushed
the
pattern-match-bytearrays
branch
from
85094f7
to
f14dfdf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview
Remarks