Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crossover for graphs with cycle #231

Merged
merged 8 commits into from
Jun 4, 2024
Merged

Conversation

YamLyubov
Copy link
Collaborator

@YamLyubov YamLyubov commented Oct 26, 2023

Adds crossover suitable for graphs with cycles. Uses http://alglobus.net/NASAwork/papers/JavaGenes2/JavaGenesPaper.html

@pep8speaks
Copy link

pep8speaks commented Oct 26, 2023

Hello @YamLyubov! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2024-06-04 10:50:40 UTC

@aim-pep8-bot
Copy link
Collaborator

aim-pep8-bot commented Oct 26, 2023

Hello @YamLyubov! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2023-10-27 13:26:52 UTC

@codecov-commenter
Copy link

codecov-commenter commented Oct 27, 2023

Codecov Report

Merging #231 (d34619c) into main (fcc23ec) will decrease coverage by 2.32%.
Report is 6 commits behind head on main.
The diff coverage is 25.80%.

@@            Coverage Diff             @@
##             main     #231      +/-   ##
==========================================
- Coverage   73.75%   71.43%   -2.32%     
==========================================
  Files         131      136       +5     
  Lines        7834     8220     +386     
==========================================
+ Hits         5778     5872      +94     
- Misses       2056     2348     +292     
Files Coverage Δ
...lem/core/optimisers/genetic/operators/crossover.py 83.96% <46.66%> (-8.82%) ⬇️
golem/core/dag/graph_utils.py 69.62% <6.25%> (-26.78%) ⬇️

... and 30 files with indirect coverage changes

@YamLyubov YamLyubov requested a review from maypink October 27, 2023 13:26
@maypink maypink mentioned this pull request Dec 19, 2023
8 tasks
@YamLyubov YamLyubov force-pushed the crossover-for-cycled-graph branch from d34619c to 8b787ce Compare May 31, 2024 13:04
@YamLyubov YamLyubov merged commit b92b61f into main Jun 4, 2024
4 checks passed
@YamLyubov YamLyubov deleted the crossover-for-cycled-graph branch June 4, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants