build: Update unit test action #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DRMPN
commented
Dec 20, 2024
.github/workflows/unit-build.yml
Outdated
Comment on lines
36
to
42
| - name: Install extra dependencies | ||
| run: | | ||
| pip install pytest-asyncio | ||
| pip install -r ./protollm_tools/llm-api/requirements.txt | ||
| - name: Extra test with pytest | ||
| run: | | ||
| pytest -s ./protollm_tools/llm-api/tests/unit |
There was a problem hiding this comment.
Сделал установку и запуск тестов последовательным, чтобы не сломать зависимости. Можно еще поменять name с extra на llm-api.
There was a problem hiding this comment.
Можно еще поменять name с extra на llm-api.
Да, наверное для понятности лучше так.
А нет смысла удялять то что установлено для первой группы тестов?
There was a problem hiding this comment.
Пока в этом нет необходимости, зависимости не ломаются при такой же установке на сервере. Проверял командой pip check, unit тесты для llm-api завершились успешно.
nicl-nno
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates action to run llm-api unit tests.
✅ Successful run - https://github.com/DRMPN/ProtoLLM/actions/runs/12435320131/job/34720881265