-
-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How to deal with a top-fixed nabvbar #140
Comments
Thanks for the report! I'd imagine we need to refactor the current jQuery Mobile oriented behaviour for anything that behaves similarly. So instead of worrying about framework we'd be running, we'd actually check for the individual case. Your PR for this improvement is welcome! |
I used a temporary fix in CSS:
|
@ain: I thought to give it a shot for a PR, so would you like to review? |
Brilliant, thanks a lot @Huppys for the great PR! I've just reviewed it as well, please check once you have time. |
@ain Is there a reason that this is not merge into the master branch? |
@bminner it introduces breaking changes which is why it is designated for |
When is the 2.0.0 release planned ? |
Added one of the few handling cases for pages with fixed nav bar.
Steps to reproduce:
position:fixed;top:0;z-index:1000
navigation bar to the page layout (very popular with mobile design)What happens: the smartbanner hides below the navbar instead of pushing it down
What should happen: the smaetbanner should push the navbar down
The text was updated successfully, but these errors were encountered: