Add option smartbanner:parent-element #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… parent element, including tests
ain
requested changes
Jul 23, 2020
Huppys
commented
Jul 24, 2020
|
Hi, is this feature present in current stable release? |
|
@Muspi no, it's scheduled for v2. |
|
Hi @ain, any idea when v2 will be released including this fix? |
|
No timeline currently, but hoping that I find some time in the next weeks! |
Hi @ain could you tell me the planed release time for v2? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In reaction of #140 I'd like to submit a PR for a new feature. The feature should allow to configure a DOM element, selected by a css selector, to be selected as parent element for the smartbanner.
I think this approach can solve the issue of displaying the smartbanner when using a sticky header.
Please review and feedback.