refactor: expose tunnel and options in the public interface #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ainghazal
force-pushed
the
feat/public-tun
branch
from
97904b2 to
130fe00
Compare
Additionally, I'm instrumenting the integration test, and merging the coverage profile so that we have a combined measure of the code exercised by coverage and unit tests. # Checklist * [x] I have read the contribution guidelines * [x] Iff you changed code related to services, or inter-service communication, make sure you update the diagrams in `ARCHITECTURE.md`. * [x] Reference issue for this pull request: NA --------- Co-authored-by: Simone Basso <[email protected]>
ainghazal
force-pushed
the
feat/public-tun
branch
from
130fe00 to
c7ce6ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose configuration options and tunnel creation as public packages. This is moving towards using the library from probe-cli.