-
-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Leverage uv
#1257
Leverage uv
#1257
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1257 +/- ##
==========================================
- Coverage 88.05% 87.88% -0.17%
==========================================
Files 67 67
Lines 5904 5904
==========================================
- Hits 5199 5189 -10
- Misses 705 715 +10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ab02d7e
to
762f9ba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My biggest concern is forcing yet another tool on contributors.
My sales pitch would be that in our context
For me personally, having worked mostly on poetry based projects, it's a single, well-known tool, that is trivial to adopt and improves developer experience by a lot. And it may be used in conjuncture with existing tools, if one prefers to take that route. |
Well, let's try it out. I've outlined my concerns and I think that |
I really, really appreciate your thoughtful reviews. |
@thehesiod: Thanks as well for your review and suggestions! |
Friendly reminder for reviewers to close any open conversations. Thanks! |
hmm maybe I'll remove that req of unresolved conversations |
That's a good requirement to have. Keep it. It facilitates more transparency in comms. |
Description of Change
Leverage
uv
for local development environment and CI/CD pipeline.Assumptions
Replace this text with any assumptions made (if any)
Checklist for All Submissions
Checklist when updating botocore and/or aiohttp versions