Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leverage uv #1257

Merged
merged 1 commit into from
Jan 16, 2025
Merged

Leverage uv #1257

merged 1 commit into from
Jan 16, 2025

Conversation

jakob-keller
Copy link
Collaborator

Description of Change

Leverage uv for local development environment and CI/CD pipeline.

Assumptions

Replace this text with any assumptions made (if any)

Checklist for All Submissions

  • I have added change info to CHANGES.rst
  • If this is resolving an issue (needed so future developers can determine if change is still necessary and under what conditions) (can be provided via link to issue with these details): closes Use best practice dependency management #1188
    • Detailed description of issue
    • Alternative methods considered (if any)
    • How issue is being resolved
    • How issue can be reproduced
  • If this is providing a new feature (can be provided via link to issue with these details):
    • Detailed description of new feature
    • Why needed
    • Alternatives methods considered (if any)

Checklist when updating botocore and/or aiohttp versions

  • I have read and followed CONTRIBUTING.rst
  • I have updated test_patches.py where/if appropriate (also check if no changes necessary)
  • I have ensured that the awscli/boto3 versions match the updated botocore version

@jakob-keller jakob-keller added dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code labels Jan 7, 2025
@jakob-keller jakob-keller self-assigned this Jan 7, 2025
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.88%. Comparing base (7432338) to head (54ce93e).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1257      +/-   ##
==========================================
- Coverage   88.05%   87.88%   -0.17%     
==========================================
  Files          67       67              
  Lines        5904     5904              
==========================================
- Hits         5199     5189      -10     
- Misses        705      715      +10     
Flag Coverage Δ
unittests 87.88% <ø> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jakob-keller jakob-keller force-pushed the uv branch 4 times, most recently from ab02d7e to 762f9ba Compare January 7, 2025 08:29
@jakob-keller jakob-keller marked this pull request as ready for review January 7, 2025 08:31
pyproject.toml Outdated Show resolved Hide resolved
Copy link
Member

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My biggest concern is forcing yet another tool on contributors.

CONTRIBUTING.rst Show resolved Hide resolved
CONTRIBUTING.rst Outdated Show resolved Hide resolved
@jakob-keller
Copy link
Collaborator Author

My biggest concern is forcing yet another tool on contributors.

My sales pitch would be that in our context uv is primarily a direct replacement of pip-tools, but also (optionally) substitutes:

  • pyenv, installers from python.org, ... (to provision Python toolchain)
  • virtualenvwrapper, venv, ...? (for managing virtual environments)
  • pip (as package installer)
  • build (as build frontend in CI/CD)

For me personally, having worked mostly on poetry based projects, it's a single, well-known tool, that is trivial to adopt and improves developer experience by a lot. And it may be used in conjuncture with existing tools, if one prefers to take that route.

@webknjaz
Copy link
Member

webknjaz commented Jan 7, 2025

Well, let's try it out. I've outlined my concerns and I think that uv pip-compile would've been less intrusive. But I suppose it's okay to attempt doing this and revert if it doesn't work out.

@jakob-keller
Copy link
Collaborator Author

Well, let's try it out. I've outlined my concerns and I think that uv pip-compile would've been less intrusive. But I suppose it's okay to attempt doing this and revert if it doesn't work out.

I really, really appreciate your thoughtful reviews.

@jakob-keller
Copy link
Collaborator Author

@thehesiod: Thanks as well for your review and suggestions!

@jakob-keller
Copy link
Collaborator Author

Friendly reminder for reviewers to close any open conversations. Thanks!

@thehesiod
Copy link
Collaborator

hmm maybe I'll remove that req of unresolved conversations

@webknjaz
Copy link
Member

hmm maybe I'll remove that req of unresolved conversations

That's a good requirement to have. Keep it. It facilitates more transparency in comms.

@webknjaz webknjaz enabled auto-merge January 16, 2025 22:38
@webknjaz webknjaz added this pull request to the merge queue Jan 16, 2025
Merged via the queue into aio-libs:master with commit abfaae4 Jan 16, 2025
11 checks passed
@jakob-keller jakob-keller deleted the uv branch January 16, 2025 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use best practice dependency management
3 participants