-
-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
run tests on ubuntu-24.04
and ubuntu-24.04-arm
CI runners
#1266
base: master
Are you sure you want to change the base?
Conversation
fd7a6c1
to
cd52ad3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1266 +/- ##
==========================================
- Coverage 87.52% 87.45% -0.07%
==========================================
Files 67 67
Lines 5917 5917
==========================================
- Hits 5179 5175 -4
- Misses 738 742 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I'll pick this up again as soon as https://github.com/orgs/community/discussions/149347 is fixed. |
This initial issue with Now, it appears that the Lambda CI images used by us so far have not been maintained in 4 years and don't ship for arm64: https://hub.docker.com/r/lambci/lambda We should probably modernize that part of our test suite ASAP. |
60b4e40
to
b9a7111
Compare
#1268 fixes the issue related to outdated Lambda container images being used. The new arm64 runners appear to be quite flaky when running the Lambda unit test. I don't think this is our fault and will give it a couple of days before trying again. |
8849614
to
e399082
Compare
The merge-base changed after approval.
I actually wrote the original implementation of lambda in moto ;) Haven't touched it in years. We should coordinate with them if there are some issues with it on arm. |
aha per https://github.com/lambci/docker-lambda?tab=readme-ov-file they've swapped to the official images here: https://github.com/aws/aws-lambda-base-images |
I think, it's good. The issue was that we were nudging moto to use outdated container images for Lambda. But #1268 should take care of that. Now it's just the flakiness of the GitHub arm runners that needs to get fixed. |
d20cbd5
to
6ae6d94
Compare
6ae6d94
to
773558a
Compare
#1275 did not fix reliability of unit tests on arm64. It's still flaky... |
834e8a5
to
b2fae20
Compare
b2fae20
to
fb76993
Compare
01ec7ea
to
df1ef64
Compare
To work around flakiness of arm64 runners, I marked them as experimental for the time being. Experimental jobs that fail do not affect the result of the CI run. |
Description of Change
ubuntu-24.04
andubuntu-24.04-arm
CI runnersAssumptions
CI on arm64 runners is currently flaky and is considered experimental. Such transient failures are not expected to affect the status of the CI run.
Checklist for All Submissions
Checklist when updating botocore and/or aiohttp versions