-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add benchmark for sending compressed payload with chunks #9840
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #9840 +/- ##
=======================================
Coverage 98.70% 98.70%
=======================================
Files 118 118
Lines 36148 36166 +18
Branches 4294 4296 +2
=======================================
+ Hits 35680 35698 +18
Misses 315 315
Partials 153 153
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #9840 will not alter performanceComparing Summary
Benchmarks breakdown
|
benchmark runs too long. |
Backport to 3.10: 💚 backport PR created✅ Backport PR branch: Backported as #9841 🤖 @patchback |
(cherry picked from commit cc5fa31)
Backport to 3.11: 💚 backport PR created✅ Backport PR branch: Backported as #9842 🤖 @patchback |
(cherry picked from commit cc5fa31)
…ed payload with chunks (#9842) Co-authored-by: J. Nick Koston <[email protected]>
…ed payload with chunks (#9841) Co-authored-by: J. Nick Koston <[email protected]>
+ bytes(range(255, 0, -1)) | ||
+ bytes(range(0, 128)) | ||
+ bytes(range(255, 0, -1)) | ||
) * 1024 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test was bad on this. The payload isn't actually large enough
For validating #9839