Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add benchmark for sending compressed payload with chunks #9840

Merged
merged 3 commits into from
Nov 12, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Nov 12, 2024

For validating #9839

@bdraco bdraco added bot:chronographer:skip This PR does not need to include a change note backport-3.10 Trigger automatic backporting to the 3.10 release branch by Patchback robot backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot labels Nov 12, 2024
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.70%. Comparing base (32ccfc9) to head (f570706).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9840   +/-   ##
=======================================
  Coverage   98.70%   98.70%           
=======================================
  Files         118      118           
  Lines       36148    36166   +18     
  Branches     4294     4296    +2     
=======================================
+ Hits        35680    35698   +18     
  Misses        315      315           
  Partials      153      153           
Flag Coverage Δ
CI-GHA 98.59% <100.00%> (+<0.01%) ⬆️
OS-Linux 98.28% <100.00%> (+<0.01%) ⬆️
OS-Windows 96.07% <100.00%> (+<0.01%) ⬆️
OS-macOS 97.35% <100.00%> (-0.01%) ⬇️
Py-3.10.11 97.21% <100.00%> (+<0.01%) ⬆️
Py-3.10.15 97.76% <100.00%> (+<0.01%) ⬆️
Py-3.11.10 97.86% <100.00%> (+<0.01%) ⬆️
Py-3.11.9 97.26% <100.00%> (+<0.01%) ⬆️
Py-3.12.7 98.34% <100.00%> (-0.01%) ⬇️
Py-3.13.0 98.32% <100.00%> (+0.04%) ⬆️
Py-3.9.13 97.12% <100.00%> (-0.01%) ⬇️
Py-3.9.20 97.72% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.16 97.29% <100.00%> (+<0.01%) ⬆️
VM-macos 97.35% <100.00%> (-0.01%) ⬇️
VM-ubuntu 98.28% <100.00%> (+<0.01%) ⬆️
VM-windows 96.07% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Nov 12, 2024

CodSpeed Performance Report

Merging #9840 will not alter performance

Comparing compressed_payload_chunks (f570706) with master (32ccfc9)

Summary

✅ 23 untouched benchmarks

🆕 1 new benchmarks

Benchmarks breakdown

Benchmark master compressed_payload_chunks Change
🆕 test_five_get_requests_with_567296_compressed_chunked_payload[pyloop] N/A 122.1 ms N/A

@bdraco
Copy link
Member Author

bdraco commented Nov 12, 2024

benchmark runs too long.
Lets go to 10 messages

@bdraco
Copy link
Member Author

bdraco commented Nov 12, 2024

10 is still too many. zlib is really slow. #9798 will fix that though

#9839 won't likely show any difference here since the bottleneck is currently zlib itself

@bdraco bdraco marked this pull request as ready for review November 12, 2024 18:13
@bdraco bdraco enabled auto-merge (squash) November 12, 2024 18:13
@bdraco bdraco merged commit cc5fa31 into master Nov 12, 2024
37 of 38 checks passed
@bdraco bdraco deleted the compressed_payload_chunks branch November 12, 2024 18:21
Copy link
Contributor

patchback bot commented Nov 12, 2024

Backport to 3.10: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.10/cc5fa31620cb23c4af09a0d17998582600980da5/pr-9840

Backported as #9841

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

Copy link
Contributor

patchback bot commented Nov 12, 2024

Backport to 3.11: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.11/cc5fa31620cb23c4af09a0d17998582600980da5/pr-9840

Backported as #9842

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Nov 12, 2024
bdraco added a commit that referenced this pull request Nov 12, 2024
…ed payload with chunks (#9842)

Co-authored-by: J. Nick Koston <[email protected]>
bdraco added a commit that referenced this pull request Nov 12, 2024
…ed payload with chunks (#9841)

Co-authored-by: J. Nick Koston <[email protected]>
+ bytes(range(255, 0, -1))
+ bytes(range(0, 128))
+ bytes(range(255, 0, -1))
) * 1024
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test was bad on this. The payload isn't actually large enough

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-3.10 Trigger automatic backporting to the 3.10 release branch by Patchback robot backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant