You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
Currently the documentation page of Manual commit states that:
When processing more sensitive data ``enable_auto_commit=False`` mode of
Consumer can lead to data loss in cases of critical failure. To avoid it we
can commit offsets manually after they were processed.
In this context the intended value of enable_auto_commit should be True, because with enable_auto_commit=False we already manually commit the message after we have processed it
Expected behaviour
The documentation page should differentiate states of setting enable_auto_commit
Environment (please complete the following information):
aiokafka version (python -c "import aiokafka; print(aiokafka.__version__)") 0.12.0:
Kafka Broker version (kafka-topics.sh --version) Not relevant:
Other information (Confluent Cloud version, etc.) Not relevant:
Describe the bug
Currently the documentation page of Manual commit states that:
See: https://aiokafka.readthedocs.io/en/stable/examples/manual_commit.html#manual-commit
In this context the intended value of
enable_auto_commit
should beTrue
, because withenable_auto_commit=False
we already manually commit the message after we have processed itExpected behaviour
The documentation page should differentiate states of setting
enable_auto_commit
Environment (please complete the following information):
python -c "import aiokafka; print(aiokafka.__version__)"
) 0.12.0:kafka-topics.sh --version
) Not relevant:Reproducible example
Go to https://github.com/aio-libs/aiokafka/blob/master/docs/examples/manual_commit.rst?plain=1#L4-L6 and see the lines
The text was updated successfully, but these errors were encountered: