Fix manual commit documentation page is misleading #1071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ods
reviewed
Nov 16, 2024
| tradeoff from *at most once* to *at least once* delivery, to achieve | ||
| *exactly once* you will need to save offsets in the destination database and | ||
| validate those yourself. | ||
| When processing sensitive data, setting ``enable_auto_commit=True`` for the |
There was a problem hiding this comment.
This way it's probably misleading too, as it's True by default. Maybe something like this?
Suggested change
| When processing sensitive data, setting ``enable_auto_commit=True`` for the | |
| When processing sensitive data, using ``enable_auto_commit=True`` (default) for the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #1070
Updates the documentation for Manual commit page