Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set with_cas to false for single get #310

Merged
merged 1 commit into from
Dec 9, 2022

Conversation

jayzfbn
Copy link
Contributor

@jayzfbn jayzfbn commented Dec 5, 2022

One line quick fix for #111
Fixes #111

@jayzfbn
Copy link
Contributor Author

jayzfbn commented Dec 5, 2022

@thehesiod fyi

@Dreamsorcerer
Copy link
Member

I'm not familiar with what the CAS part is, so I'll defer to @thehesiod as to whether this is correct behaviour now.

@jayzfbn
Copy link
Contributor Author

jayzfbn commented Dec 9, 2022

I think we're waiting for your approval @thehesiod

@thehesiod
Copy link
Contributor

@Dreamsorcerer I actually proposed this change, so I approve of it =)

@jayzfbn
Copy link
Contributor Author

jayzfbn commented Dec 9, 2022

@Dreamsorcerer I actually proposed this change, so I approve of it =)

Gotta get that green checkmark :-)

@Dreamsorcerer
Copy link
Member

Yeah, sorry, more just me not getting back to it this week.

@Dreamsorcerer Dreamsorcerer merged commit ce6c43f into aio-libs:master Dec 9, 2022
@Dreamsorcerer
Copy link
Member

@jayzfbn @thehesiod If you're interested in doing a little more debugging, we seem to have some problems in aiocache when using aiomcache for the backend: aio-libs/aiocache#585 aio-libs/aiocache#587

@jayzfbn
Copy link
Contributor Author

jayzfbn commented Dec 28, 2022

I'm currently dealing with a dying furnace at my house right now (fortunately I live in California so it's not that cold) but I could probably take a look at this in the coming weeks if you can wait that long.

Just to confirm we don't think this is directly related to the changes we were making just general debug/improvement, ya?

@Dreamsorcerer
Copy link
Member

I'm currently dealing with a dying furnace at my house right now (fortunately I live in California so it's not that cold) but I could probably take a look at this in the coming weeks if you can wait that long.

Whenever you like, no rush.

Just to confirm we don't think this is directly related to the changes we were making just general debug/improvement, ya?

I don't believe so. Most of the tests have not been running on that repository for years, so I've just been getting everything up and running again, those are the still failing parts (though there are some warnings as well, which I'm trying to resolve now).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

get() actually issues "gets" command on the wire
3 participants