-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
set with_cas to false for single get #310
Conversation
@thehesiod fyi |
I'm not familiar with what the CAS part is, so I'll defer to @thehesiod as to whether this is correct behaviour now. |
I think we're waiting for your approval @thehesiod |
@Dreamsorcerer I actually proposed this change, so I approve of it =) |
Gotta get that green checkmark :-) |
Yeah, sorry, more just me not getting back to it this week. |
@jayzfbn @thehesiod If you're interested in doing a little more debugging, we seem to have some problems in aiocache when using aiomcache for the backend: aio-libs/aiocache#585 aio-libs/aiocache#587 |
I'm currently dealing with a dying furnace at my house right now (fortunately I live in California so it's not that cold) but I could probably take a look at this in the coming weeks if you can wait that long. Just to confirm we don't think this is directly related to the changes we were making just general debug/improvement, ya? |
Whenever you like, no rush.
I don't believe so. Most of the tests have not been running on that repository for years, so I've just been getting everything up and running again, those are the still failing parts (though there are some warnings as well, which I'm trying to resolve now). |
One line quick fix for #111
Fixes #111