Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Navigation Issue in AnimationListView in the Sample Project #2528

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

Take111
Copy link
Contributor

@Take111 Take111 commented Jan 29, 2025

I fixed the navigation issue in the AnimationListView in the sample, which was not working on iOS 18.

Additionally, the following warning was occurring:

Do not put a navigation destination modifier inside a "lazy” container, like List or LazyVStack. These containers create child views only when needed to render on screen. Add the navigation destination modifier outside these containers so that the navigation stack can always see the destination. There's a misplaced navigationDestination(for:destination:) modifier for type Item. It will be ignored.

Attachments

Before After After(iPad)
Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-01-29.at.15.27.51.mp4
Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-01-29.at.15.26.37.mp4
Simulator.Screen.Recording.-.iPad.Pro.13-inch.M4.-.2025-01-29.at.15.25.43.mov

Copy link
Member

@calda calda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Helpful, thanks!

@calda calda merged commit f93abb0 into airbnb:master Jan 29, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants