Update typescript to the latest version along with eslint, and prettier #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you, @ismailcherri ! |
Rudeg
approved these changes
Jun 8, 2022
|
For some, including myself, this did not fix the issue described in #150. Was there anything else you might have done to resolve JS comments being placed inside JSX blocks @ismailcherri? |
|
@mirague I don't recall doing anything particularly except changing the Typescript version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue: #150
I used this wonderful tool to migrate our partially migrated code base to Typescript.
It worked fine but we faced the issue of incorrect jsx comments. It worked with the specified version in the issue mentioned above, but we needed to use the latest Typescript version.
In this PR I updated Typescript, Eslint and Prettier. Also, I had to make some fixes related to changes in function definitions in the latest Typescript version.
I divided the PR into smaller commits for easier review. I can merge them into single one if required.