-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add entry for brevo to publicApi definition mappers #382
base: main
Are you sure you want to change the base?
fix: add entry for brevo to publicApi definition mappers #382
Conversation
Currently, one cannot use the API https://reference.airbyte.com/reference/createsource for Brevo. This is because the mapping from the name to the source definition ID is not present. We introduce it here.
/create-oss-pr |
@pmossman @pedroslopez related pull request #384 |
There are some internal conversation to change how it the current behavior. @JonsSpaghetti can you provide some insights, looks @airbytehq/platform-deployments is responsible for API right now. |
@gabeleonpma We've been considering deprecating the source name functionality and instead using definition IDs for creating these sources. We're still working on creating a connector definition endpoint to make this fully usable, but can you try by using the top level |
@gabeleonpma Here's an example curl request that you can use as a template:
|
What
400
, saying that the valuebrevo
of thesourceType
could not be found.How
sourceType
brevo
is mapped to its corresponding source definition ID.Can this PR be safely reverted and rolled back?