Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add entry for brevo to publicApi definition mappers #382

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

gabeleonpma
Copy link

What

  • Currently, one cannot use the API https://reference.airbyte.com/reference/createsource for Brevo. This is because the mapping from the name to the source definition ID is not present.
  • This results in requests in responses of type 400, saying that the value brevo of the sourceType could not be found.

How

  • The mapping for the sourceType brevo is mapped to its corresponding source definition ID.

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

Currently, one cannot use the API https://reference.airbyte.com/reference/createsource for Brevo. This is because the mapping from the name to the source definition ID is not present. We introduce it here.
@CLAassistant
Copy link

CLAassistant commented Jan 15, 2025

CLA assistant check
All committers have signed the CLA.

@marcosmarxm
Copy link
Member

/create-oss-pr

@szemek
Copy link
Contributor

szemek commented Jan 24, 2025

@pmossman @pedroslopez related pull request #384
Content of file is generated with Python script.

@marcosmarxm
Copy link
Member

There are some internal conversation to change how it the current behavior. @JonsSpaghetti can you provide some insights, looks @airbytehq/platform-deployments is responsible for API right now.

@JonsSpaghetti
Copy link
Contributor

@gabeleonpma We've been considering deprecating the source name functionality and instead using definition IDs for creating these sources. We're still working on creating a connector definition endpoint to make this fully usable, but can you try by using the top level definitionId parameter with the value e2276f19-1c19-4d4e-ae6c-7df3c9c4ad49?

@JonsSpaghetti
Copy link
Contributor

@gabeleonpma Here's an example curl request that you can use as a template:

--header 'Content-Type: application/json' \
--header 'Authorization: Bearer YOUR_ACCESS_TOKEN_HERE' \
--data '{
    "name": "test source",
    "workspaceId": "YOUR_WORKSPACE_ID_HERE",
    "configuration": {"api_key": "API_KEY", "start_date": "2025-01-01T00:00:00Z"},
    "definitionId": "e2276f19-1c19-4d4e-ae6c-7df3c9c4ad49"
}'```

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants