Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use ubuntu-24.04 explicitly (resolves CI warnings) #244

Merged
merged 2 commits into from
Jan 22, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions .github/workflows/connector-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ concurrency:
jobs:
cdk_changes:
name: Get Changes
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
permissions:
statuses: write
pull-requests: read
Expand Down Expand Up @@ -62,7 +62,7 @@ jobs:
# Forked PRs are handled by the community_ci.yml workflow
# If the condition is not met the job will be skipped (it will not fail)
# runs-on: connector-test-large
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
timeout-minutes: 360 # 6 hours
strategy:
fail-fast: false
Expand Down Expand Up @@ -123,6 +123,10 @@ jobs:
repository: airbytehq/airbyte
ref: master
path: airbyte
- name: Set up Python
uses: actions/setup-python@v5
with:
python-version: "3.10"
- name: Test Connector
if: steps.no_changes.outputs.status != 'cancelled'
timeout-minutes: 90
Expand All @@ -131,7 +135,7 @@ jobs:
POETRY_DYNAMIC_VERSIONING_BYPASS: "0.0.0"
run: |
cd airbyte
make tools.airbyte-ci-binary.install
make tools.airbyte-ci-dev.install
airbyte-ci \
--ci-report-bucket-name=airbyte-ci-reports-multi \
connectors \
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pdoc_preview.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ on:

jobs:
preview_docs:
runs-on: ubuntu-latest
runs-on: ubuntu-24.04

steps:
- name: Checkout code
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pdoc_publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ concurrency:

jobs:
publish_docs:
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
environment:
name: "github-pages"
url: ${{ steps.deployment.outputs.page_url }}
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/pypi_publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ on:
jobs:
build:
name: Build Python Package
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
steps:
- name: Detect Release Tag Version
if: startsWith(github.ref, 'refs/tags/v')
Expand Down Expand Up @@ -107,7 +107,7 @@ jobs:

publish_cdk:
name: Publish CDK version to PyPI
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
needs: [build]
permissions:
id-token: write
Expand Down Expand Up @@ -156,7 +156,7 @@ jobs:
(github.event_name == 'workflow_dispatch' &&
github.event.inputs.publish_to_dockerhub == 'true'
)
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
needs: [build]
environment:
name: DockerHub
Expand Down Expand Up @@ -257,7 +257,7 @@ jobs:
env:
VERSION: ${{ needs.build.outputs.VERSION }}
IS_PRERELEASE: ${{ needs.build.outputs.IS_PRERELEASE }}
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
steps:
- uses: actions/setup-python@v5
with:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/pytest_fast.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ on:
jobs:
test-build:
name: Build and Inspect Python Package
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
steps:
- name: Checkout code
uses: actions/checkout@v4
Expand All @@ -36,7 +36,7 @@ jobs:
pytest-fast:
name: Pytest (Fast)
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
steps:
# Common steps:
- name: Checkout code
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/python_lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ on:
jobs:
ruff-lint-check:
name: Ruff Lint Check
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
steps:
# Common steps:
- name: Checkout code
Expand All @@ -32,7 +32,7 @@ jobs:

ruff-format-check:
name: Ruff Format Check
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
steps:
# Common steps:
- name: Checkout code
Expand All @@ -55,7 +55,7 @@ jobs:

mypy-check:
name: MyPy Check
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
steps:
# Common steps:
- name: Checkout code
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release_drafter.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
permissions:
contents: write
pull-requests: write
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
steps:
# Drafts the next Release notes as Pull Requests are merged into "main"
- uses: release-drafter/release-drafter@v6
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/semantic_pr_check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ permissions:
jobs:
validate_pr_title:
name: Validate PR title
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
steps:
- uses: amannn/action-semantic-pull-request@v5
if: ${{ github.event.pull_request.draft == false }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/slash_command_dispatch.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ jobs:
slashCommandDispatch:
# Only allow slash commands on pull request (not on issues)
if: ${{ github.event.issue.pull_request }}
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
steps:
- name: Slash Command Dispatch
id: dispatch
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/test-command.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ on:
jobs:
start-workflow:
name: Append 'Starting' Comment
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
steps:
- name: Get PR JSON
id: pr-info
Expand Down Expand Up @@ -127,7 +127,7 @@ jobs:
log-success-comment:
name: Append 'Success' Comment
needs: [pytest-on-demand]
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
steps:
- name: Append success comment
uses: peter-evans/create-or-update-comment@v4
Expand All @@ -143,7 +143,7 @@ jobs:
# This job will only run if the workflow fails
needs: [pytest-on-demand, start-workflow]
if: always() && needs.pytest-on-demand.result == 'failure'
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
steps:
- name: Append failure comment
uses: peter-evans/create-or-update-comment@v4
Expand Down
Loading