Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Source Stripe: Update CDK version to prepare for low-code migration #49940

Merged
merged 9 commits into from
Feb 4, 2025

Conversation

maxi297
Copy link
Contributor

@maxi297 maxi297 commented Dec 19, 2024

What

In order to prepare source-stripe for the low-code migration, we needed to update the CDK version as it'll need to leverage CDK updates.

How

  • Adding some tests that were passing on master to add a safety net in a very specific case
  • Updating the CDK version from ^5 to ^6

User Impact

None for the customer as the behavior should be the same. However, the devs will be able to leverage CDK ^6 updates

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

Copy link

vercel bot commented Dec 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 4, 2025 11:46am

Copy link
Collaborator

@lazebnyi lazebnyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lazebnyi
Copy link
Collaborator

lazebnyi commented Feb 4, 2025

/approve-regression-tests

Check job output.

✅ Approving regression tests

@lazebnyi lazebnyi merged commit 6bc2e03 into master Feb 4, 2025
30 checks passed
@lazebnyi lazebnyi deleted the stripe-migration/updating-cdk-version branch February 4, 2025 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/stripe
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants